Always show emoji category tabs, decouple them from toolbar hiding - #2620
Always show emoji category tabs, decouple them from toolbar hiding#2620MiMoHo wants to merge 1 commit into
Conversation
The emoji category tab strip is navigation, not a toolbar: without it, categories can only be reached by swiping through all pages, which users don't discover (see HeliBorg#2546). Show it unconditionally in the emoji view, as an extension on top of the keyboard. The clipboard toolbar now simply follows the main toolbar setting: hidden toolbar means no clipboard toolbar. This makes the toolbar_hiding_global setting obsolete, so it is removed. Since the strips now either match the main view (clipboard) or are always shown (emoji tabs), the secondary keyboard height adjustment is not needed anymore. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The reason for adding |
|
Thanks @eranl, that's a fair correction and I stand corrected — I framed this as "the bar is navigation, not a tool", but the actual rationale in #1606 was about height/space consistency when the toolbar is hidden, not about what the bar is for. Sorry for mischaracterising it. To keep the discussion grounded, I measured what this PR actually does on an emulator (Pixel-ish, 1080×2400, toolbar hidden, 100% emoji size), using the IME window's
So you're right that this PR reintroduces a mode-switch height change — but only for the emoji view, and by exactly the category-bar height (~105 px). The clipboard view stays height-consistent (its bar now simply follows the toolbar). What the emoji view gains for that +105 px is: the full "no-bars" number of rows and the category bar, instead of today's either/or (bar + fewer rows, or more rows + no bar). The reason I think that trade is worth it specifically for the emoji view: switching to emojis is usually a short, focused detour — you go there to pick an emoji and come back. In that moment, an extra visible row helps you find the emoji faster, and the temporarily taller keyboard is a very short-lived cost. It also sidesteps #2546, where a user simply couldn't find most emojis because, with the default settings, the only way to change category was swiping (which people don't discover). Relying on swipe-only navigation as the fallback is exactly what bit that user. That said, I don't want to steamroll a deliberate decision, so it's really @Helium314's call. Roughly the options:
My preference (and the motivation from the linked discussion) is 1, because it's the only option that gives both discoverable category navigation and a full set of rows. But if the constant-height invariant is something you'd rather not break, 2 is a smaller change that still fixes the "can't find emojis" problem. Happy to rework the PR toward whichever direction you prefer. |
|
Option 2 is already supported (the setting's default should possibly be changed to off, to prevent the issue you mentioned). |
Draft for discussion – this reverses part of the design from #1606, so I'd like your opinion before polishing it.
Motivation
With the toolbar hidden and "Hide clipboard and emoji toolbars too" enabled (which is the default,
PREF_TOOLBAR_HIDING_GLOBAL = true), the emoji palette loses its category tab strip. Categories can then only be reached by swiping through every page, which users don't discover – see #2546 ("Can't find all list of emojis", diagnosed in-thread as exactly this setting).The underlying issue: the emoji category tab strip is navigation, not a toolbar. It's the only way to jump between emoji categories, so hiding it as if it were a row of toolbar tools removes core functionality rather than just decluttering.
Change
toolbar_hiding_globalsetting no longer has a distinct meaning and is removed (with a small migration inAppUpgradeto drop the stored pref). The secondary-keyboard height adjustment tied to it is no longer needed either.This follows a "works best for most" approach: one less setting, and the emoji navigation is never accidentally hidden.
Open questions
toolbar_hiding_global? The alternative is to keep the setting but make it only affect the clipboard toolbar (never the emoji category tabs). I went with removal for simplicity, but can switch to the narrower change if you'd prefer to keep the option.Testing
Built and tested on an emulator with the toolbar hidden:
assembleDebugandtestRunTestsUnitTestpass.Refs #2546, #374, #1606.